Skip to content

test(multi-select): add out-of-bounds group drag boundary test - #27

Merged
makuchpatryk merged 2 commits into
feat-multi-selectfrom
copilot/sub-pr-25
Feb 23, 2026
Merged

test(multi-select): add out-of-bounds group drag boundary test#27
makuchpatryk merged 2 commits into
feat-multi-selectfrom
copilot/sub-pr-25

Conversation

Copilot AI commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

The header checklist claimed boundary handling for group drag outside the board, but no test exercised that path or verified moves don't increment on an invalid group move.

Changes

  • Header checklist: Added entry – drag&drop grupy klocków poza granicę planszy: licznik moves NIE rośnie to match actual coverage
  • Test 16 (grupowy drag poza granicę planszy nie zwiększa moves): Selects pieces at positions 0 and 1, drags piece 1 onto piece 0 (offset = −1). isGroupMoveValid rejects the move since piece 0 would land at position −1, and the test asserts the counter stays at 0.
// Pieces 0 and 1 selected; dragging piece 1 → piece 0 produces offset = -1.
// isGroupMoveValid rejects: piece 0 would move to position -1 (out of bounds).
await dragPiece(page, 1, 0);
await expect(page.locator('text=/0 Move/')).toBeVisible();

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@vercel

vercel Bot commented Feb 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
perplex-image Ready Ready Preview, Comment Feb 23, 2026 10:05pm

…d update header checklist

Co-authored-by: makuchpatryk <19875907+makuchpatryk@users.noreply.github.com>
Copilot AI changed the title [WIP] Update multi-select feature enhancements based on review feedback test(multi-select): add out-of-bounds group drag boundary test Feb 23, 2026
Copilot AI requested a review from makuchpatryk February 23, 2026 22:05
@makuchpatryk
makuchpatryk marked this pull request as ready for review February 23, 2026 22:05
@makuchpatryk
makuchpatryk merged commit 3c7a239 into feat-multi-select Feb 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants